-
Notifications
You must be signed in to change notification settings - Fork 114
Add SQL, schema, metadata, and DAG for modeling prospects table from … #7368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…snowflake in BigQuery
+ Add team lead as owner, representative engineer as alternate + Choose better friendly name
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
501286b
to
b205eaf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
name: features | ||
description: 'ML features for the prospect item. Note: These features are being | ||
passed through for ML use and will not be engineered in the warehouse | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new lines look slightly odd. They should be safe to delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be okay with that, but I will say I ran schema format
, and on several occasions was finding the build to fail when I changed shape-related, non-substantive things like these newlines (I forget if this is one of the specific things) so I'm tempted to say "if the linter likes it, leave it."
sql/moz-fx-data-shared-prod/snowflake_migration/prospects_v1/query.sql
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
…uery.sql Co-authored-by: Anna Scholtz <[email protected]>
Integration report for "Update sql/moz-fx-data-shared-prod/snowflake_migration/prospects_v1/query.sql"
|
Queries for modeling raw snowplow data about prospects | ||
(candidate links to be curated by ML models and the editorial team for New Tab). | ||
|
||
user_facing: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This failed to deploy because the dataset doesn't match expectations (if it's non-user-facing, it must be suffixed with _derived
or _external
). We should probably catch this in CI.
…snowflake in BigQuery
Description
Related Tickets & Documents
Reviewer, please follow this checklist